add: cli foundation#349
Conversation
|
There was a problem hiding this comment.
For now, we will only keep the code inside Compose. We can move the spec and skills folder to the PRD repo.
I like the overall structure. You did a great job with this. It will definitely help.
I'll make sure to review each part to gain a better understanding of what's done and not before merging.
| - `src/adapters`: External library adapters, currently hashing through `viem`. | ||
| - `src/resolver`: Dependency keys, registry, and resolver. | ||
| - `src/utils`: Generic reusable helpers for files, regex, terminal output, and Solidity text parsing. | ||
| - `src/templates`: Solidity template assets copied into generated projects. |
There was a problem hiding this comment.
We should use the compose package. We will import from there.
Only specific facets or modules could be there like a CounterFacet and error examples that won't be supported in the standard library.
There was a problem hiding this comment.
Thank you, I'm glad it helps.
I will move the spec and skills folders to the PRD repo, and update the code according to your review.
| "label": "AccessControl", | ||
| "required": { | ||
| "AccessControlDataFacet": { | ||
| "path": "./src/templates/access/AccessControl/Data/AccessControlDataFacet.sol" |
There was a problem hiding this comment.
It should be the path for the imports too.
2 participants
Add architecture foundation for cli under cli/project-template